Skip to content

Conversation

AltamashShaikh
Copy link
Contributor

Description:

React steps updated for history change step
Fixes: #PG-2779.

Review

@AltamashShaikh AltamashShaikh marked this pull request as ready for review June 13, 2023 07:11
@AltamashShaikh AltamashShaikh requested review from snake14 and removed request for snake14 June 13, 2023 07:11
);
},
fetchSetupStep1_3() {
const historyPageFAQLink = ''; // TODO: Need to update this when FAQ is ready
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snake14 Will update the FAQ url once ready, rest all is good for a review

Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't actually follow the steps, since I didn't want to take the time to setup a React app, but they look good in the no data page when I update to the corresponding core branch.

@AltamashShaikh AltamashShaikh merged commit d3d9819 into 5.x-dev Jun 14, 2023
@AltamashShaikh AltamashShaikh deleted the PG-2779-react-followup branch June 14, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants