Skip to content

Reverting Tag Manager JavaScript Changes #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 14, 2023

Conversation

snake14
Copy link
Contributor

@snake14 snake14 commented Apr 14, 2023

Description:

Reverting Tag Manager JavaScript Changes because they appear to be preventing some tracking requests.

Review

@AltamashShaikh
Copy link
Contributor

@tsteur Could you have a look once ?

@tsteur
Copy link
Member

tsteur commented Apr 14, 2023

I haven't tested it but looking at the other PRs that looks good 👍

@snake14 snake14 merged commit 1698cd4 into 4.x-dev Apr 14, 2023
@snake14 snake14 deleted the pg-2754-reverting-pg-1718-paq-fix branch April 14, 2023 06:11
@utrautmann
Copy link

Hello @snake14 ,
I found this ticket in the Matomo 4.14.2 release notes from 18. April 2023.
What does this ticket mean exactly? I'm asking because my clients are always unsure how to use Tag Manager and the normal tracking script together. So far I advise against sharing.

@snake14
Copy link
Contributor Author

snake14 commented Apr 19, 2023

Hi @utrautmann . Sadly, it was reverting the changes I made to make Matomo Tag Manager and the regular tracker work better together. There was apparently a race condition or something that we missed in our testing. So, for now, it's best not to mix the two. If you have customers that need to call _pag.push() methods while using MTM, I'd recommend doing so inside of a Custom HTML tag.
We have a new ticket to do some further investigation and see if we can fix the changes that were reverted, but if we're able to fix it, it probably won't be included till Matomo 5.0.0 or later.

@utrautmann
Copy link

@snake14 : Thank you very much for your answer. I actually don't recommend my clients to use both tracking approaches together. In the past I saw often JavaScript errors in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants