Skip to content

Added code to create default container for idsite:1 if not created #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2023
Merged

Added code to create default container for idsite:1 if not created #606

merged 1 commit into from
Mar 9, 2023

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Added code to create default container for idsite:1 if not created.
Fixes: #PG-2606

Review

@AltamashShaikh AltamashShaikh marked this pull request as ready for review March 8, 2023 04:03
@AltamashShaikh AltamashShaikh requested a review from snake14 March 8, 2023 04:03
@AltamashShaikh
Copy link
Contributor Author

@snake14 To test this, I created a new setup of Matomo

  1. git clone git@github.com:matomo-org/matomo.git
  2. cd matomo
  3. composer install
  4. git submodule init
  5. git submodule update
  6. Replaced plugins/TagManager/TagManager.php with this file
  7. Completed the setup and activated the TagManager plugin

snake14
snake14 approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I didn't test a completely new Matomo install, but I had an install that didn't have TagManager activated yet. When I activated the plugin, the default container was created for site 1 👍

@AltamashShaikh AltamashShaikh merged commit 623e2e0 into 4.x-dev Mar 9, 2023
@AltamashShaikh AltamashShaikh deleted the PG-2606 branch March 9, 2023 01:52
@AltamashShaikh AltamashShaikh mentioned this pull request Mar 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snake14 snake14 snake14 approved these changes

Assignees
No one assigned
Labels
Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AltamashShaikh @snake14