Skip to content

Add escaping for percent sign for ScrollReachTriggerPercentageDescription key #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2022
Merged

Add escaping for percent sign for ScrollReachTriggerPercentageDescription key #574

merged 1 commit into from
Nov 17, 2022

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Added escaping for percent for ScrollReachTriggerPercentageDescription key.

Review

snake14
snake14 approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The percent sign displayed before and after I checked out this branch, so I'm guessing it's working as expected.

@snake14 snake14 merged commit b4009db into 4.x-dev Nov 17, 2022
@snake14 snake14 deleted the fix-percent-escape branch November 17, 2022 00:43
@elabuwa elabuwa changed the title Added escaping for percent for ScrollReachTriggerPercentageDescription key Add escaping for percent sign for ScrollReachTriggerPercentageDescription key Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snake14 snake14 snake14 approved these changes

Assignees
No one assigned
Labels
Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AltamashShaikh @snake14