Skip to content

Add translations for tags,triggers and variables #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 13, 2022
Merged

Add translations for tags,triggers and variables #568

merged 8 commits into from
Nov 13, 2022

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Added translations for tags,triggers and variables.
Fixes: #PG-1515

Review

@AltamashShaikh
Copy link
Contributor Author

@snake14 can you do a early initial review of this PR ?
I am yet to complete few more changes which I will do tomorrow, so if there is anything which I should change I will add it too.

snake14
snake14 approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Most of my comments are just about translations that already exist.

The only thing not to forget is to register all of the new translations in the Piwik\Plugins\TagManager\TagManager::getClientSideTranslationKeys() method once you're done.

@AltamashShaikh AltamashShaikh marked this pull request as ready for review November 11, 2022 05:06
@AltamashShaikh AltamashShaikh merged commit 8d4a420 into 4.x-dev Nov 13, 2022
@AltamashShaikh AltamashShaikh deleted the PG-1515-translate-hardcoded-text branch November 13, 2022 22:58
@elabuwa elabuwa changed the title Added translations for tags,triggers and variables Add translations for tags,triggers and variables Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snake14 snake14 snake14 approved these changes

Assignees
No one assigned
Labels
Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AltamashShaikh @snake14