Skip to content

Fix for update not applied when upgrading from 4.12.1 #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2022
Merged

Fix for update not applied when upgrading from 4.12.1 #558

merged 1 commit into from
Oct 25, 2022

Conversation

bx80
Copy link
Contributor

@bx80 bx80 commented Oct 24, 2022

Description:

Renames the migration from 4.12.1-b1 to 4.12.3-b1, additional PR in Matomo core will increase the version number to 4.12.3-b1

matomo-org/matomo#19905

Review

@bx80 bx80 self-assigned this Oct 24, 2022
@bx80 bx80 added this to the Current sprint milestone Oct 24, 2022
@bx80 bx80 mentioned this pull request Oct 24, 2022
Merged
11 tasks
@AltamashShaikh
Copy link
Contributor

@bx80 Tried checking out to this branch and ran ./console core:update and it shows Everything is already up to date.
Screenshot from 2022-10-25 10-17-53
Screenshot from 2022-10-25 10-19-59

@bx80
Copy link
Contributor Author

bx80 commented Oct 25, 2022

@AltamashShaikh I think you'd need to checkout the core branch for this fix as that depends on this branch but also increments the version in core so the migration can run.

snake14
snake14 approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Since the core branch is already merged, I was able to do a pull on 4.x-dev for the core matomo project, run git submodule update (which updated TagManager to this branch), and then ./console core:update. The migration script ran as expected.

@snake14 snake14 merged commit d0d50cc into 4.x-dev Oct 25, 2022
@snake14 snake14 deleted the tag-manager-update-fix branch October 25, 2022 20:29
@innocraft-automation innocraft-automation removed this from the Current sprint milestone Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snake14 snake14 snake14 approved these changes

Assignees

@bx80 bx80

Labels
Critical Needs Review Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bx80 @AltamashShaikh @snake14 @innocraft-automation