Allow dynamic height on Tag manager preview #477
Conversation
This commit adds a feature that makes the preview bar of the tag manager vertically resizable. It adds a handle with which the user can adjust the height of the bar. The height is also saved in a cookie and restored when reloading the preview site.
|
@korve Thanks for the PR seems to work as expected. |
|
@tsteur Can you have a look once? |
|
@AltamashShaikh I didn't review the code but from a UX perspective that works for me 👍 nice feature @korve and thanks a lot for the contribution 🎉 . They only thing I was wondering if should maybe keep a higher min-height of the debug window to make sure some portion of it is always visible? Otherwise people might by accident change the min height, and then it's barely visible and they are thinking it's not shown at all anymore when in fact it is. That could reduce some possible frustrations and support emails. |
|
@korve can we limit the resize to a certain height to make it always visible ? |
Yep, i'll look into it. |
|
I think i've managed to limit the height. Currently it's set to 10% of the viewport. I had to implement some feature testing to support IE < 11. Specifically |
Description:
This commit adds a feature that makes the preview bar of the tag manager vertically resizable. It adds a handle with which the user can adjust the height of the bar. The height is also saved in a cookie and restored when reloading the preview site.
I've implemented this because i had massive problems using the preview mode on my daily job. I never had enough real estate to view all tags, triggers etc. I hope this makes the preview bar more usable.
See the following video to get a idea of what this commit provides.
resizable-preview-bar.mp4
Review