Prepare plugin for Marketplace #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
commented
Jun 23, 2020
| # (PIWIK_TEST_TARGET=maximum_supported_piwik). | ||
| # You can also specify a specific Matomo version | ||
| # (PIWIK_TEST_TARGET=2.16.0-b1). | ||
| - PIWIK_TEST_TARGET=11524-cvar |
There was a problem hiding this comment.
Note: That needs to be changed to 4.x-dev once the PR in matomo is merged
|
Before publishing to the marketplace we should also add a README and maybe some screenshots |
This was referenced Jun 24, 2020
|
@tsteur @diosmosis could someone do a quick review. I've created #2 as follow up for the changes we may need to apply before releasing the plugin on the marketplace... |
|
@sgiehl did some tests and worked fine for me. Tracked custom variables for various slots in various scopes. It's shown in visitor log and the reports. The manage page works as well 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to publish the plugin to the Marketplace as of Matomo 4, there are a few adjustments required.
Additionally some parts from core need to be moved to this plugin, so core works without it.
Note: The current 4.x-dev branch includes the latest files from 4.x-dev branch of matomo repo. (The history was transfered using git filter-branch).
refs matomo-org/matomo#16090