Allow switching between request methods and post token by default #72

tsteur · 2020-07-15T22:48:49Z

follow up from https://github.com/matomo-org/matomo-php-tracker/pull/71/files
to fix #43

I haven't fully tested it. If someone could continue and test it this would be great.

Bulk requests would keep behaving the same. All other requests should behave like this:

You can now force POST of all requests. When set, all parameters will be posted. This can be useful if there's a problem on the webserver re URL length or the requests are very long.
By default we still use GET
- Unless a token auth is specified. In this case we use POST but we only POST the token, nothing else. This way log replay will still be possible.
  - Unless you force GET request method. Then token_auth will still be sent using GET which can be useful if you are having redirect issues for example.

…usion Have been getting these warnings quite often and a user mentioned it recently as well. I reckon this should fix it > Warning: include_once(): Failed opening './PiwikTracker.php' for inclusion (include_path='/vendor/pear/pear_exception:/vendor/pear/console_getopt:/vendor/pear/pear-core-minimal/src:/vendor/pear/archive_tar:.:/usr/local/Cellar/php/7.4.6_1/share/php/pear') in /vendor/matomo/matomo-php-tracker/MatomoTracker.php on line 2110

Fix include_once warning Failed opening './PiwikTracker.php' for inclusion

added warning about redirects for setRequestMethod()

prevent method from being set to GET while doing Bulk Requests

Method is now set to POST as bool, instead of a string, since it should remain defaulted to GET and there is no need to have the option to set it to GET. URL is spliced in URL and parameters which are now fed to the POST payload for both cURL and stream.

Snake case converted to camel case. Reverted back to the method selection of 'POST' (intended). Added a warning about Log Analytics.

Method setRequestMethodNonBulk() added to allow (non bulk) POST requests

silvershadowcc · 2020-07-18T00:33:14Z

I used the following script.

<?php
$path = __DIR__ . '/data.txt';

file_put_contents($path, json_encode(array('get' => $_GET, 'post' => $_POST), JSON_PRETTY_PRINT), FILE_APPEND);

The token was set for every request.

I got as output:
setRequestMethodNonBulk('POST') -> Only POST, but token is missing
setRequestMethodNonBulk('GET') -> Only GET, token included
setRequestMethodNonBulk() not used -> Only GET, but token is missing (in both GET and POST)

Expected behaviour:
setRequestMethodNonBulk('POST') -> Only POST, token included
setRequestMethodNonBulk('GET') -> Only GET. token included
setRequestMethodNonBulk() not used -> GET, but token through POST

tsteur · 2020-07-20T00:51:13Z

Thanks @silvershadowcc I've tested it now as well and fixed it. In my case it worked nicely.

silvershadowcc · 2020-07-23T21:55:54Z

I will test it again this weekend. Also with redirects.

fixed typo and passed test as such

silvershadowcc · 2020-07-26T09:48:23Z

In my case it works nicely as well. Got the results as stated in the expected behaviour above. Redirecting also works fine (using cURL).

I did find a typo for which I have made PR #74 in this branch. This needs to be fixed in order for redirects to work.

fixed typo

tsteur · 2020-07-27T04:38:56Z

@sgiehl technically, this one could break something so would need to release ideally a 3.0.0 but considering Matomo 1 is still including 1.X in https://github.com/matomo-org/matomo/blob/3.14.1-b1/composer.json#L47 maybe it be fine to release a 2.1 version afterwards? Can also make it 3.0 I'm not quite sure what the policy is so far.

Technically, something could break because if a token_auth is used, and the user is using eg http://example.com/matomo.php as tracking API, and this URL redirects to https://example.com/matomo.php and not curl is used (or an old PHP version is used), then it might execute the tracking request without the posted tracking parameter. So it's quite an edge case but problems could still happen. Wonder if we would simply release a 3.0 afterwards?

We POST tokens by default to have it secure by default.

sgiehl · 2020-07-27T07:30:53Z

@tsteur version 2.0 was only released for the new package name. Even though all versions are now available on both names, as we are using the same repo 🤷
Should those changes be included for Matomo 3.x? If not we could move it to 4.x-dev branch and release a new major version once Matomo 4 beta will be finished...

tsteur · 2020-07-27T07:36:04Z

They shouldn't be included in 3.x.
Could release a new major version before the beta? or some beta version like 3.0-be1? Then we could already include it in first Matomo 4 beta?

sgiehl · 2020-07-27T07:48:04Z

Matomo 4 currently uses the 4.x-dev branch of this repo: https://github.com/matomo-org/matomo/blob/4.x-dev/composer.json#L38

tsteur · 2020-07-27T20:23:51Z

Thanks for your help @silvershadowcc very appreciated

tsteur and others added 11 commits June 16, 2020 14:30

Update PiwikTracker.php

68a2178

Merge pull request #69 from matomo-org/inclusionwarning

96cfab7

Fix include_once warning Failed opening './PiwikTracker.php' for inclusion

function setRequestMethod added for POST

3ee2532

Update MatomoTracker.php

b76389f

added warning about redirects for setRequestMethod()

indentation

5891331

prevent method change for bulk requests

81d6605

prevent method from being set to GET while doing Bulk Requests

reworked

4eac561

Method is now set to POST as bool, instead of a string, since it should remain defaulted to GET and there is no need to have the option to set it to GET. URL is spliced in URL and parameters which are now fed to the POST payload for both cURL and stream.

Casing, non-boolean method selection

597712c

Snake case converted to camel case. Reverted back to the method selection of 'POST' (intended). Added a warning about Log Analytics.

Allow switching between request methods and post token by default

b7ad0c9

add docs

d525d37

tsteur added the Needs Review label Jul 15, 2020

silvershadowcc added 2 commits July 16, 2020 01:17

Update MatomoTracker.php

5423ea2

Update MatomoTracker.php

167fb7e

silvershadowcc mentioned this pull request Jul 16, 2020

Method setRequestMethodNonBulk() added to allow (non bulk) POST requests #71

Merged

tsteur added 3 commits July 16, 2020 12:57

Merge pull request #71 from silvershadowcc/patch-1

effc715

Method setRequestMethodNonBulk() added to allow (non bulk) POST requests

Merge branch 'master' into m43

098f3d0

merge master

f0973fb

fix token and post was not set

03cb308

fixed typo

54268f1

fixed typo and passed test as such

Merge pull request #74 from silvershadowcc/patch-2

8be2714

fixed typo

tsteur added this to the Current sprint milestone Jul 27, 2020

tsteur changed the base branch from master to 4.x-dev July 27, 2020 20:23

tsteur merged commit e4c6829 into 4.x-dev Jul 27, 2020

tsteur deleted the m43 branch July 27, 2020 20:23

sgiehl mentioned this pull request Jul 28, 2020

Use new tracker mehtod to set a custom dimension matomo-org/matomo#16245

Merged

tsteur mentioned this pull request Sep 7, 2020

handle new cookie values #77

Closed

innocraft-automation removed this from the Current sprint milestone Jan 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Allow switching between request methods and post token by default #72

Allow switching between request methods and post token by default #72

Uh oh!

tsteur commented Jul 15, 2020

Uh oh!

silvershadowcc commented Jul 18, 2020

Uh oh!

tsteur commented Jul 20, 2020

Uh oh!

silvershadowcc commented Jul 23, 2020

Uh oh!

silvershadowcc commented Jul 26, 2020 •

edited

Loading

Uh oh!

tsteur commented Jul 27, 2020

Uh oh!

sgiehl commented Jul 27, 2020

Uh oh!

tsteur commented Jul 27, 2020

Uh oh!

sgiehl commented Jul 27, 2020

Uh oh!

tsteur commented Jul 27, 2020

Uh oh!

Uh oh!

Allow switching between request methods and post token by default #72

Allow switching between request methods and post token by default #72

Uh oh!

Conversation

tsteur commented Jul 15, 2020

Uh oh!

silvershadowcc commented Jul 18, 2020

Uh oh!

tsteur commented Jul 20, 2020

Uh oh!

silvershadowcc commented Jul 23, 2020

Uh oh!

silvershadowcc commented Jul 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tsteur commented Jul 27, 2020

Uh oh!

sgiehl commented Jul 27, 2020

Uh oh!

tsteur commented Jul 27, 2020

Uh oh!

sgiehl commented Jul 27, 2020

Uh oh!

tsteur commented Jul 27, 2020

Uh oh!

Uh oh!

silvershadowcc commented Jul 26, 2020 •

edited

Loading