fix: Check for cURL error before throwing exception in sendRequest method #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thod Description: This commit addresses an issue where an exception was being thrown unconditionally in the `sendRequest` method of the `MatomoTracker` class when a cURL request failed. The error handling logic now checks if `curl_error($ch)` returns a non-empty value before throwing a `\RuntimeException`. This ensures that exceptions are only thrown when there is an actual cURL error, preventing unnecessary exceptions from being raised. This change improves error handling and provides more accurate feedback when cURL requests fail.
sgiehl
approved these changes
Mar 25, 2024
|
Hi @sgiehl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This commit addresses an issue where an exception was being thrown unconditionally in the
sendRequestmethod of theMatomoTrackerclass when a cURL request failed. The error handling logic now checks ifcurl_error($ch)returns a non-empty value before throwing a\RuntimeException. This ensures that exceptions are only thrown when there is an actual cURL error, preventing unnecessary exceptions from being raised. This change improves error handling and provides more accurate feedback when cURL requests fail.