Skip to content

Remove installed.json from build #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Remove installed.json from build #126

merged 2 commits into from
Mar 25, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Mar 25, 2021

@sgiehl sgiehl added this to the Current sprint milestone Mar 25, 2021
Copy link
Collaborator

@Findus23 Findus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you maybe also add package-lock.json while you are on it?
matomo-org/matomo-nginx#62

@sgiehl
Copy link
Member Author

sgiehl commented Mar 25, 2021

@Findus23 sure, I've added it

@diosmosis diosmosis merged commit 178626e into master Mar 25, 2021
@diosmosis diosmosis deleted the rminstalledjson branch March 25, 2021 18:39
@diosmosis
Copy link
Member

FYI @mattab

@tsteur
Copy link
Member

tsteur commented Mar 25, 2021

btw not sure if important... in WP-Matomo I also exclude some more files that aren't really needed see https://github.com/matomo-org/wp-matomo/blob/develop/.gitattributes eg composer.travis.json and changelogs etc which may include similar results etc? In the end you could probably still sometimes find out what dependency is used depending on readme (as it changes over versions), etc.

also we ship Matomo with the changelog etc see eg https://demo.matomo.org/CHANGELOG.md

fyi @Findus23

@Findus23
Copy link
Collaborator

Hm, CHANGELOG.md might be useful to keep in the package (but maybe we should add a rule to not publish it).

@tsteur
Copy link
Member

tsteur commented Mar 26, 2021

This would be maybe possible in nginx but don't think in core for apache. That's because we usually don't have an .htaccess file in the root directory and adding one now could break a lot of things as some would be using a custom .htaccess just like we do on the cloud. We could add one though if none exists yet maybe (but then it be hard to make changes to it in the future). I was just bringing it up because it was a concern someone could find out the Matomo version number using this composer file but there be also still many other ways.

@Findus23
Copy link
Collaborator

Didn't think of that (I'm not that familiar with Apache).
Maybe we really need to think about moving the whole Matomo directory outside of the public web directory (at least optionally).

@tsteur
Copy link
Member

tsteur commented Mar 28, 2021

For that particular case could otherwise change in the build.zip the changelog.md with a link to https://developer.matomo.org/changelog I suppose. Of course it wouldn't be 100% accurate/the same if they upgrade / install an older version that is not the latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

vendor/composer/installed.json is exposed publicly Deny package-lock.json
5 participants