-
Notifications
You must be signed in to change notification settings - Fork 27
Remove installed.json from build #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you maybe also add package-lock.json while you are on it?
matomo-org/matomo-nginx#62
@Findus23 sure, I've added it |
FYI @mattab |
btw not sure if important... in WP-Matomo I also exclude some more files that aren't really needed see https://github.com/matomo-org/wp-matomo/blob/develop/.gitattributes eg also we ship Matomo with the changelog etc see eg https://demo.matomo.org/CHANGELOG.md fyi @Findus23 |
Hm, CHANGELOG.md might be useful to keep in the package (but maybe we should add a rule to not publish it). |
This would be maybe possible in nginx but don't think in core for apache. That's because we usually don't have an |
Didn't think of that (I'm not that familiar with Apache). |
For that particular case could otherwise change in the |
fixes matomo-org/matomo#17378
fixes matomo-org/matomo-nginx#62