Ship Matomo with Provider and Custom Variables plugin #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For say 6 months or 1 year we should include Provider and Custom Variables plugin still in Matomo 4.X so there are no complications when upgrading. We won't enable them though by default. Once most users have updated to Matomo 4 (in 6 months or 1 year), we could stop shipping it with the release. For people that update from the most recent 3.14.1 version it will update the plugins through the marketplace anyway. For other users updating from an older version it will show an update is available because of matomo-org/matomo#16323 but the plugins will be deactivated by core when updating and the admin has to activate them again. I reckon it be good to still ship it with Matomo at least for a few months simply to prevent possible issues where the plugins would be otherwise deactivated or not updated. Refs
This was referenced Aug 20, 2020
sgiehl
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For say 6 months or 1 year we should include Provider and Custom Variables plugin still in Matomo 4.X so there are no complications when upgrading. We won't enable them though by default. Once most users have updated to Matomo 4 (in 6 months or 1 year), we could stop shipping it with the release.
For people that update from the most recent 3.14.1 version it will update the plugins through the marketplace anyway. For other users updating from an older version it will show an update is available because of matomo-org/matomo#16323 but the plugins will be deactivated by core when updating and the admin has to activate them again.
I reckon it be good to still ship it with Matomo at least for a few months simply to prevent possible issues where the plugins would be otherwise deactivated or not updated.
Refs