Skip to content

prevent building stable version that has already been released #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 19, 2019

Conversation

Findus23
Copy link
Collaborator

@Findus23 Findus23 commented Sep 3, 2018

references matomo-org/matomo#13380
fixes #78

@aureq I feel like this probably breaks your debian build script if you build it after Matt published the release.

@aureq
Copy link
Contributor

aureq commented Nov 18, 2018

@Findus23 Thanks for the pull request. No, this shouldn't break anything on my side, but could break @mattab workflow.

Copy link
Contributor

@aureq aureq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with your idea and I understand why you're adding it. But it may be necessary to rebuild a given version. So could you please add something like --rebuild-version as a way to override this?

@Findus23
Copy link
Collaborator Author

@aureq Breaking Matt's workflow is more or less the intention of this change 🙂
(see matomo-org/matomo#13380)

Having a way to override sounds useful, but as we don't have a general way to read parameters, I am not sure how we should handle this.

@mattab mattab merged commit a47651b into matomo-org:master Apr 19, 2019
@Findus23 Findus23 deleted the disallow-rebuild branch May 3, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

prevent to build a stable release when it's already built
3 participants