Added new command line option '--php-binary' #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ify the PHP binary to use
sgiehl
reviewed
Oct 21, 2019
|
I've updated this PR to make it compatible with the latest changes on 4.x-dev branch. |
|
I've updated to 4.2.0 today. It seems the parameter is still missing in the official build, but its mentioned in the changelog: https://matomo.org/changelog/matomo-4-2-0/ What happend? |
|
Guess we forgot to update the submodule before building the release 🤔 🙈 |
|
Ok, no problem, i'll wait for the next release :) |
|
Sorry for the inconvenience nevertheless. I'll later build a github action to do that automatically, so we don't forget that in the future again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address issue 215, I've added a new command-line option,
--php-binary, that let's the user specify the PHP binary to use. It defaults tophp, which is what thephpBinaryvariable was hardcoded to before. In other words, if the option is not given, the script should behave exactly as before.