Run _get_token_auth after config object is initialized. #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a problem where _get_token_auth would fail because it uses the piwik object which depends on the config object which is just in the process if being created.
|
Thanks for the quick new PR 👍 will update the submodule in matomo-org/matomo#12350 and wait for build results |
mattab
added a commit
to matomo-org/matomo
that referenced
this pull request
Dec 13, 2017
mattab
added a commit
to matomo-org/matomo
that referenced
this pull request
Dec 13, 2017
* Log Analytics: use latest submodule * Update submodule to include bugfix * Update submodule to include bug fix matomo-org/matomo-log-analytics#201
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem discussed in #200. The
_get_token_authmethod in theConfigurationclass may use thepiwikobject which depends on theconfigobject being present. This means that the_get_token_authmethod must not be called from theConfigurationcontructor, but only after theconfigobject has been created.