Skip to content

Only issue an invalid line status, when the line was really invalid and skipped #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2017

Conversation

mattab
Copy link
Member

@mattab mattab commented Dec 8, 2017

Currently the invalid line is reported even for lines that are still imported.

Here is an example of the issue. The log file has 590887 lines, and 584895 were imported successfully. But the output also reports 594622 lines which is not true.

Logs import summary
-------------------

    584895 requests imported successfully
    0 requests were downloads
    596860 requests ignored:
        0 HTTP errors
        0 HTTP redirects
        594622 invalid log lines
        2147 filtered log lines
        0 requests did not match any known site
        0 requests did not match any --hostname
        91 requests done by bots, search engines...
        0 requests to static resources (css, js, images, ico, ttf...)
        0 requests to file downloads did not match any --download-extensions

Website import summary
----------------------

    584895 requests imported to 1 sites
        1 sites already existed
        0 sites were created:

    0 distinct hostnames did not match any existing site:

Performance summary
-------------------

    Total time: 1676 seconds
    Requests imported per second: 348.82 requests per second

Currently the invalid line is reported even for lines that are still imported.

Here is an example of the issue. The log file has 590887 lines, and 584895 were imported successfully. But the output also reports  594622 lines which is not true.

```
Logs import summary
-------------------

    584895 requests imported successfully
    0 requests were downloads
    596860 requests ignored:
        0 HTTP errors
        0 HTTP redirects
        594622 invalid log lines
        2147 filtered log lines
        0 requests did not match any known site
        0 requests did not match any --hostname
        91 requests done by bots, search engines...
        0 requests to static resources (css, js, images, ico, ttf...)
        0 requests to file downloads did not match any --download-extensions

Website import summary
----------------------

    584895 requests imported to 1 sites
        1 sites already existed
        0 sites were created:

    0 distinct hostnames did not match any existing site:

Performance summary
-------------------

    Total time: 1676 seconds
    Requests imported per second: 348.82 requests per second

```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants