Fix transparency issue in all Opera browser icons #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron <admin@datahoarder.dev>
|
Hi, Many thanks for noticing the issue. Unfortunately fixing it is a bit more complicated. I use a bash script to automatically (and reproducibly) convert the images from the src/ directory (which in this case is a symlink to the opera logos from https://github.com/alrra/browser-logos) using imagemagic. But for whatever weird reason, when you add e.g. a green border to the logo using convert opera.png -bordercolor green -border 1x1 out.pngit replaces all existing transparency with green. I fixed this now in f85567c which should not only fix the opera icons, but a lot of others too. |
|
@Findus23 Just wanted to confirm that the issue is fixed in Matomo 4.0+. Thanks! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Findus23 This pull request updates the current Opera browser icons, which all have unwanted whitespace in them, to be fully transparent. You can see the difference by opening the example images below in a new tab.
The new browser icons are all sourced from https://github.com/alrra/browser-logos.
Current icon
New icon
Edit: Here's also a screenshot from Matomo v3.14.1 showing the current icon's whitespace issue: