Adds "Segmented Visitor Log" icon to more reports and subtables #9478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d46189d to
fe1d3b5
Compare
| @@ -1,7 +1,279 @@ | |||
| <?xml version="1.0" encoding="utf-8" ?> | |||
| <results> | |||
| <result idSite="1"> | |||
| <result date="2010-01-03" /> | |||
| <result date="2010-01-03"> | |||
There was a problem hiding this comment.
I think you might need to modify https://github.com/piwik/piwik/blob/2.16.0-b1/tests/PHPUnit/System/TwoVisitsWithCustomVariablesSegmentMatchNONETest.php#L58-L77 and maybe add a special case so it doesn't match anything?
There was a problem hiding this comment.
Good point. I'll try to adjust that.
3791977 to
67e540b
Compare
|
PR looks good! Can you maybe squash the commits and then merge? If not a direct merge should be ok too |
sgiehl
added a commit
that referenced
this pull request
Jan 12, 2016
Adds "Segmented Visitor Log" icon to more reports and subtables
| @@ -0,0 +1,4 @@ | |||
| <?xml version="1.0" encoding="utf-8" ?> | |||
| <result> | |||
| <row>Unknown</row> | |||
There was a problem hiding this comment.
@sgiehl would it be possible to have this test generate real values so it shows that the auto suggest for this new segment works as expected?
There was a problem hiding this comment.
I'll issue a pull request for that...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9501