Improve region name fetching #23235
Merged
Improve region name fetching #23235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
approved these changes
Apr 17, 2025
michalkleiner
pushed a commit
that referenced
this pull request
Apr 30, 2025
michalkleiner
pushed a commit
that referenced
this pull request
Apr 30, 2025
11 tasks
caddoo
pushed a commit
that referenced
this pull request
May 1, 2025
caddoo
added a commit
that referenced
this pull request
May 2, 2025
* Cherry pick ubuntu-24.04 update excl. submodule update (#23097) * Update expected test results * Ensure login username is provided as string value (#23117) * Prevent automated linking in emails (#23248) * Prevent automated linking in emails * prevent linking on some more elements * add some tests --------- Co-authored-by: caddoo <1169490+caddoo@users.noreply.github.com> * Improve handling of prefixUrl parameter in API.listAllMethods (#23247) * Fix escaping in realtime report (#23245) * Ensure all translations required for password confirmation are always loaded (#23176) * Suppress errors when trying to access javaEnabled property (#23161) Co-authored-by: caddoo <matthew.caddoo@gmail.com> * Ensure to discard campaign names with invalid type (#23229) * Prevent concurrency when removing sites (#23230) * Prevent warning when no email is set for current user (#23228) * Improve region name fetching (#23235) * Unset actionsByVisitId after consumption (#23234) * Use https URLs (#23072) * Use https URLs * Build vue files * use matomo.org instead of piwik.org in some links * updates expected UI test file --------- Co-authored-by: innocraft-automation <innocraft-automation@users.noreply.github.com> * Update screenshot * Tweak regex for host checks --------- Co-authored-by: Marc Neudert <marc@innocraft.com> Co-authored-by: Stefan Giehl <stefan@matomo.org> Co-authored-by: caddoo <1169490+caddoo@users.noreply.github.com> Co-authored-by: caddoo <matthew.caddoo@gmail.com> Co-authored-by: innocraft-automation <innocraft-automation@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When fetching the region name by countryCode and regionCode, the full list of regions is first converted to contain only the
name, dropping all other information.The iteration itself is usually not an issue, but it builds up when having to run it a couple thousand times.
Replacing the data conversion step with a direct access reduced the time per call from 5 milliseconds on a test machine to 5 microseconds. And it prevents the function from allocating any memory during the array conversion as nothing is changed.
Review