Add Github workflow to allow for automatic preview releases #22367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mneudert
reviewed
Jul 3, 2024
michalkleiner
commented
Jul 4, 2024
michalkleiner
commented
Jul 4, 2024
sgiehl
reviewed
Jul 4, 2024
bf8567c to
f9dfc98
Compare
fddc18f to
1f1320c
Compare
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
mneudert
approved these changes
Jul 31, 2024
Co-authored-by: Marc Neudert <marc.neudert@gmail.com>
1f1320c to
aa63485
Compare
sgiehl
reviewed
Aug 5, 2024
Comment on lines
23
to
28
| # TODO: remove manual dispatch after testing and enable cron | ||
| workflow_dispatch: | ||
| branches: | ||
| - 5.x-dev | ||
| #schedule: | ||
| # - cron: '0 1 * * *' # 1am daily |
There was a problem hiding this comment.
Should we change that before merging or leave it in, so we can test that manually before having it run as cron?
There was a problem hiding this comment.
I would say we merge it as workflow_dispatch and run it once manually before updating it to a schedule. Just so we don't have to wait for the first scheduled run to see if any of the recent repository changes has an unforeseen impact 🤔
mneudert
requested changes
Aug 8, 2024
mneudert
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds a new workflow that determines what the new preview version should be, updates the version file, runs the tests for the new version and on success publishes a preview release.
If any of the steps fail along the way the action stops and doesn't create a release.
This introduces 5.x-preview branch that is always reset to the top of 5.x-dev before the version number is increased and tests are run, it can technically be deleted as it will be recreated every time.
The check for code changes is done between the newest preview version tag and 5.x-dev, excluding the line that contains the version number change in core/Version.php.
We can consider extending the range of changes we want to ignore in a follow up.
We either need to merge this for testing after a code review or people can run this in their own forks.
Review