Define default collation for TiDB tables #22271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
approved these changes
Jun 4, 2024
| { | ||
| return $this->getDbSettings()->getEngine(); | ||
| } | ||
|
|
||
| protected function getTableRowFormat(): string | ||
| { | ||
| return $this->getDbSettings()->getRowFormat(); |
There was a problem hiding this comment.
Should we maybe fully move the getRowFormat away from DbSettings into the Schema? That way we could also simply leave it away for TiDb in general. Or if ever needed use another one for TiDb if they start adding something around that.
michalkleiner
approved these changes
Jun 4, 2024
We can address this separately if needed, I'll merge this now so that we can run rebase and another set of tests for TiDB. |
mneudert
added a commit
that referenced
this pull request
Sep 11, 2024
* Define consistent db settings access * Define reusable table creation options * Create all tables with explicit row format * Define default collation for TiDB tables * Use table create options from schema in migrations * Create TiDB databases with default collation * Update OmniFixture dump to include ROW_FORMAT
mneudert
added a commit
that referenced
this pull request
Sep 13, 2024
11 tasks
sgiehl
pushed a commit
that referenced
this pull request
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
TiDB uses
utf8mb4_general_binas the default collation when creating a table. Compared to the MySQL default ofutf8mb4_general_cithe sorting of some database results will be different.This PR changes the table/database creation code to be more consistent across engines and actions:
Always define
ROW_FORMAT=dynamicPreviously, the row format was only defined for tables created during a migration.
For InnoDB, all tables currently should default to
ROW_FORMAT=DYNAMIC, adding it to all tables by default should (as far as I know) not be an issue.Note: TiDB currently ignores the
ROW_FORMATand always usesCOMPACT(docs).Set a default collation for TiDB tables
When TiDB is configured, and the (default)
utf8mb4charset is used, all created tables will be created with a matchingCOLLATE=utf8mb4_0900_ai_ci.Set a default collation for TiDB databases
Creating a database also sets the default collation if TiDB is configured.
Refs DEV-18061
Review