Skip to content

Escape hover tooltip text in SiteSelector #22243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 27, 2024

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Added code to escape hover text in SiteSelector
Fixes: AS-301.

Review

@AltamashShaikh AltamashShaikh added the Needs Review PRs that need a code review label May 22, 2024
@AltamashShaikh AltamashShaikh requested a review from a team May 22, 2024 06:43
@sgiehl sgiehl added this to the 5.1.0 milestone May 22, 2024
@sgiehl
Copy link
Member

sgiehl commented May 22, 2024

Actually the title attribute are currently not always converted to HTML tooltips. That only happens in the user management, as it uses the v-tooltips directive. The site selector on the main page is included with vue-entry at the moment, and the title attributes are left as they are, so there the text is now displayed encoded when hovering 🙈
So guess we either need to use v-tooltips in the site selector directly, to ensure it's always used, or implement something to prevent v-tooltips from parsing tooltips inside other components. 🤔
@matomo-org/core-reviewers Does anyone have a suggestion/preference which way to go?

@michalkleiner
Copy link
Contributor

@sgiehl @AltamashShaikh I'd vote for using v-tooltips component in all the places consistently and avoid exceptions to that if possible.

@AltamashShaikh
Copy link
Contributor Author

@sgiehl @michalkleiner Made some changes, is that what was expected ?

@sgiehl sgiehl merged commit f9c5504 into 5.x-dev May 27, 2024
@sgiehl sgiehl deleted the AS-301-escape-hover-text-site-dropdown branch May 27, 2024 09:12
@sgiehl sgiehl changed the title Added code to escape hover text in SiteSelector, AS-301 Escape hover tooltip text in SiteSelector May 28, 2024
@sgiehl sgiehl added the c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review
Development

Successfully merging this pull request may close these issues.

3 participants