Skip to content

Add role attribute to parent unordered lists #22183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 6, 2024
Merged

Add role attribute to parent unordered lists #22183

merged 2 commits into from
May 6, 2024

Conversation

textagroup
Copy link
Contributor

@textagroup textagroup commented May 3, 2024 •
edited
Loading

Description:

Minor change which adds the role attribute to the parent of some list items with the menuitem role to the _topBar.twig template

Review

@textagroup
Copy link
Contributor Author

fixes #22188

@textagroup textagroup marked this pull request as ready for review May 5, 2024 23:18
@michalkleiner michalkleiner added this to the 5.1.0 milestone May 6, 2024
@michalkleiner michalkleiner added c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review labels May 6, 2024
@sgiehl sgiehl linked an issue May 6, 2024 that may be closed by this pull request
[Bug] Improve accessibility of top menu (missing role attributes) #22188
Closed
4 tasks
sgiehl
sgiehl approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution @textagroup

@sgiehl sgiehl merged commit 0ab04ea into matomo-org:5.x-dev May 6, 2024
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.

[Bug] Improve accessibility of top menu (missing role attributes)
3 participants
@textagroup @sgiehl @michalkleiner