Skip to content

Replace jQuery.dotdotdot with pure CSS #22115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 16, 2024
Merged

Replace jQuery.dotdotdot with pure CSS #22115

merged 4 commits into from
Apr 16, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 15, 2024

Description:

fixes #20941

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Technical debt Issues the will help to reduce technical debt labels Apr 15, 2024
@sgiehl sgiehl added this to the 5.2.0 milestone Apr 15, 2024
@sgiehl sgiehl requested a review from a team April 15, 2024 12:36
@michalkleiner
Copy link
Contributor

@sgiehl do we have this covered by a UI test (and it still passes) or there's no UI test for this?

@sgiehl
Copy link
Member Author

sgiehl commented Apr 15, 2024

There is no UI test covering this, as the marketplace updates stream is mocked to an empty set.
It basically only affects this widget on the admin home screen:
image

@sgiehl sgiehl added the Needs Review PRs that need a code review label Apr 15, 2024
@michalkleiner
Copy link
Contributor

michalkleiner commented Apr 15, 2024 •
edited
Loading

Can you please help me where do I find those Marketplace updates? Can't seem to see it anywhere. Found it right after I posted the question. All good.

@michalkleiner michalkleiner added the c: Design / UI For issues that impact Matomo's user interface or the design overall. label Apr 15, 2024
@michalkleiner
Copy link
Contributor

michalkleiner commented Apr 15, 2024 •
edited
Loading

I think we should hold off merging until we create 5.1.x-dev branch or we add it to 5.1.0-b2 as we are not in feature freeze yet.

@sgiehl
Copy link
Member Author

sgiehl commented Apr 16, 2024

Let's include it in 5.1.0-b2

@sgiehl sgiehl modified the milestones: 5.2.0, 5.1.0 Apr 16, 2024
@sgiehl sgiehl merged commit d0b89d2 into 5.x-dev Apr 16, 2024
@sgiehl sgiehl deleted the removejqdotdotdot branch April 16, 2024 08:26
@sgiehl sgiehl mentioned this pull request Nov 18, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner approved these changes

Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Technical debt Issues the will help to reduce technical debt
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.

Dependency jquery.dotdotdot has a non-commercial license
2 participants
@sgiehl @michalkleiner