Connect free trial start with marketplace account creation #22088
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mneudert when an invalid email is added, the value in the error message has escaped quotes showing as words. Screenshot added to JIRA. |
054a827 to
b4a4c23
Compare
| } as unknown as ModalOptions; | ||
|
|
||
| if (immediateTransition) { | ||
| modalOptions.inDuration = 0; |
There was a problem hiding this comment.
The previous construction with the ternary operator was breaking the onOpenEnd callback causing it to never be called for the undefined value, so it's best if the config option is not set at all when not needed.
|
@mneudert I've added a small tweak to focus the email field when the modal is open and also allow submitting it by Enter key. Have updated the UI test screenshots accordingly. |
caddoo
approved these changes
Apr 12, 2024
caddoo
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If a Matomo instance has no license key, and the user is a super user, the "start free trial" CTA will currently show an informational dialog how to obtain a license manually.
This PR changes that dialog to allow direct creation of a new marketplace account from within an instance. After the account was created, the new license key will automatically be added to the instance, and then the requested free trial will be started.
In addition to this new workflow, the visuals of the existing "wait while we start your free trial" loading modal have been update to match the "create an account and start your free trial" modal.
Uses DEV-17921
Refs DEV-17920
Refs DEV-17922
Review