Skip to content

Never send a user creation email to anonymous user #22070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 4, 2024

Description:

When a user is created (not invited), a notification mail is sent to the user, who created the new one.
This currently also happens when users are created by the system (e.g. through plugins or commands).
In this case no user is currently logged in, causing the email being send to the anonymous user.
This PR will avoid this.

fixes #22068

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Apr 4, 2024
@sgiehl sgiehl added this to the 5.1.0 milestone Apr 4, 2024
@sgiehl sgiehl requested a review from a team April 4, 2024 07:08
@sgiehl sgiehl requested a review from a team April 8, 2024 13:21
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test to adjust/add to check this behaviour doesn't regress in future? If not then good to go.

@sgiehl sgiehl merged commit 3a9c211 into 5.x-dev Apr 9, 2024
@sgiehl sgiehl deleted the dev-17923 branch April 9, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Development

Successfully merging this pull request may close these issues.

[Bug] Do not send Notification Email to anonymous user
2 participants