Fix: Testing feature might break saving a segment #22065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wasn't able to replicate the failure locally before applying the fix here, are there any specific steps to take? What I've tried:
|
|
This issue is in "needs review" but there has been no activity for 7 days. ping @matomo-org/core-reviewers |
michalkleiner
approved these changes
Apr 12, 2024
4214e61 to
dc25317
Compare
b54134d to
78a9f3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When the "test segment" feature is used, when adding a new segment an error might be thrown when clicking on save, after the visitors log popover has been closed.
This happened due to the fact, that opening a popover manipulates the url hash. As the segment editor was watching the whole url, instead of only the relevant segment part, it was resetting the current segment definition to the one from url hash.
Only watching the segment part, fixes this problem, and the segment is stored correctly again.
In addition this PR fixes an error that occurred, when the "add condition" link was clicked to fast, after the segment editor was opened.
fixes #22028
Review