Add 'Require feature consent for campaigns tracking' JS tracker code generator option #22013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0e9d121 to
6e435f5
Compare
cef112e to
bf01c29
Compare
6e435f5 to
a984d41
Compare
5fff27b to
6c7d58e
Compare
60233b7 to
46802b2
Compare
6c7d58e to
185ab9b
Compare
11 tasks
d8a48ec to
a4b443e
Compare
7ba0458 to
5bbd8b9
Compare
Base automatically changed from
dev-17829-update-tracker-to-support-feature-consent
to
5.x-dev
March 17, 2024 21:32
Not using named params yet so we need to provide all if we want to skip some with default values.
…ered in UI tests as well
3ebb6c3 to
0f733c6
Compare
caddoo
approved these changes
Mar 17, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Follow up to #21999 this adds an advanced options checkbox to add the
_paq.push(["disableCampaignParameters"]);line to the generated JS tracker code.JS.tracker.campaigns.consent.mp4
Note 1: The copy may still change which would mean updating the UI screenshots.
Note 2: Before merging this PR, the Tag Manager PR should be merged first and the reference to the submodule updated here before this PR is merged.
Review