Avoid strlen(null) call on undefined "idvisitor" property #22991
Conversation
The "idvisitor" property can be undefined/null, this must be taken into account to avoid this error: > strlen(): Passing null to parameter matomo-org#1 ($string) of type string is deprecated in /.../core/Tracker/Visit.php on line 583
|
Hi @mbrodala. Thanks for creating the PR. Can you share some more information on under what circumstance the visitorid can be null or undefined? Do we rather need to ensure it's never set as empty or undefined to the visit properties? |
|
We are tracking a regular page view request and saw this message in the There are various other checks in this class to avoid an empty/undefined |
There was a problem hiding this comment.
Good find @mbrodala and yeah, I can confirm other places in the class do do a check for the visit property to not be empty. We can adjust the code so the check is done in a similar way here as well.
This is more in line with other locations in this class. Co-authored-by: Michal Kleiner <mk@011.nz>
The "idvisitor" property can be undefined/null, this must be taken into account to avoid this error:
Description:
Please include a description of this change and which issue it fixes. If no issue exists yet please include context and what problem it solves.
Review