Skip to content

Block installation if installation is older than 3 days #22750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 25, 2024
Merged

Block installation if installation is older than 3 days #22750

merged 6 commits into from
Nov 25, 2024

Conversation

caddoo
Copy link
Contributor

@caddoo caddoo commented Nov 12, 2024 •
edited by mneudert
Loading

Description:

Sometimes people can put Matomo on their server and leave it sitting their for an extended period, possibly opening themselves up to bad actors.

This PR locks the install out 3 days after first access.

Refs DEV-18623.

Review

@mneudert mneudert force-pushed the dev-18623-lock-out-installer-after-3-days branch 4 times, most recently from 31e8134 to 8c637c1 Compare November 19, 2024 18:27
@mneudert mneudert force-pushed the dev-18623-lock-out-installer-after-3-days branch 2 times, most recently from a332203 to e1a9e9b Compare November 19, 2024 22:36
@mneudert mneudert force-pushed the dev-18623-lock-out-installer-after-3-days branch from e1a9e9b to 8ce8af9 Compare November 20, 2024 20:08
@mneudert mneudert force-pushed the dev-18623-lock-out-installer-after-3-days branch from 8ce8af9 to 0935963 Compare November 20, 2024 20:54
mneudert
mneudert reviewed Nov 20, 2024
View reviewed changes
@mneudert mneudert added this to the 5.2.0 milestone Nov 20, 2024
@mneudert mneudert added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review labels Nov 20, 2024
@mneudert mneudert marked this pull request as ready for review November 20, 2024 21:04
@mneudert mneudert requested a review from a team November 20, 2024 21:04
sgiehl
sgiehl reviewed Nov 21, 2024
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Can be approved and merged, once the FAQ link was adjusted.

@mneudert mneudert merged commit 55b28a4 into 5.x-dev Nov 25, 2024
24 of 26 checks passed
@mneudert mneudert deleted the dev-18623-lock-out-installer-after-3-days branch November 25, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mneudert mneudert mneudert left review comments

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@caddoo @mneudert @sgiehl