Skip to content

Show owner name in marketplace card for each plugin #22694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 17, 2024
Merged

Show owner name in marketplace card for each plugin #22694

merged 5 commits into from
Oct 17, 2024

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Show owner name in marketplace card for each plugin
Fixes: #PG-3773

Review

@AltamashShaikh AltamashShaikh marked this pull request as ready for review October 17, 2024 12:05
@AltamashShaikh AltamashShaikh added the Needs Review PRs that need a code review label Oct 17, 2024
@sgiehl sgiehl changed the title Show owner name in marketplace card for each plugin, #PG-3773 Show owner name in marketplace card for each plugin Oct 17, 2024
sgiehl
sgiehl requested changes Oct 17, 2024
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. Otherwise this looks good to me.

@AltamashShaikh AltamashShaikh requested a review from sgiehl October 17, 2024 13:36
sgiehl
sgiehl approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to merge, once the tests passed.

@sgiehl sgiehl added this to the 5.2.0 milestone Oct 17, 2024
@sgiehl sgiehl merged commit 8d16f90 into 5.x-dev Oct 17, 2024
25 of 26 checks passed
@sgiehl sgiehl deleted the PG-3773-show-owner branch October 17, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

@michalkleiner michalkleiner Awaiting requested review from michalkleiner

@caddoo caddoo Awaiting requested review from caddoo

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AltamashShaikh @sgiehl