Skip to content

Improve title of ecommerce overview widget in Dashboard #22675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 12, 2024
Merged

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented Oct 11, 2024

Description:

fixes #19779

It'll look like this now:
image
image

To reproduce:

  • Go to Dashboard
  • Add the widget Ecommerce -> Overview
  • You'll see the proper naming of the widget
  • Previously this was confusing what kind of overview that is

It doesn't impact the Ecommerce Overview reporting page itself.

(Ref DEV-13863)

Review

@michalkleiner
Copy link
Contributor

Hi @tsteur, thank you for the PR. It looks like the failure of the system core tests are related to this change, can you please adjust those as well? Thanks!

@michalkleiner michalkleiner added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review labels Oct 11, 2024
@michalkleiner michalkleiner added this to the 5.2.0 milestone Oct 11, 2024
@michalkleiner michalkleiner requested a review from a team October 11, 2024 09:05
@tsteur
Copy link
Member Author

tsteur commented Oct 11, 2024

Thanks @michalkleiner that's fixed now

@michalkleiner michalkleiner merged commit 5827fe7 into 5.x-dev Oct 12, 2024
25 checks passed
@michalkleiner michalkleiner deleted the m19779 branch October 12, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review
Development

Successfully merging this pull request may close these issues.

Make title for E-Commerce overview desktop widget more descriptive
2 participants