Skip to content

Allow to pass a single string to write as a console message #22648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

michalkleiner
Copy link
Contributor

@michalkleiner michalkleiner commented Oct 9, 2024

Description:

A small quality of life improvement that I came across when working on #22634.

The method indicates that it would write a single message but an array was required to wrap even a single string. This change allows to pass in both a single string or an array of strings.

Review

@michalkleiner michalkleiner added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Technical debt Issues the will help to reduce technical debt labels Oct 9, 2024
@michalkleiner michalkleiner added this to the 5.2.0 milestone Oct 9, 2024
@michalkleiner michalkleiner added the Needs Review PRs that need a code review label Oct 9, 2024
@michalkleiner michalkleiner requested a review from a team October 9, 2024 14:44
Co-authored-by: Stefan Giehl <stefan@matomo.org>
@sgiehl sgiehl merged commit 61be6ac into 5.x-dev Oct 10, 2024
24 of 25 checks passed
@sgiehl sgiehl deleted the console-messages branch October 10, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Needs Review PRs that need a code review Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. Technical debt Issues the will help to reduce technical debt
Development

Successfully merging this pull request may close these issues.

2 participants