Skip to content

Adds some tests around correct handling of formulas in CSV export #22646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2024
Merged

Adds some tests around correct handling of formulas in CSV export #22646

merged 1 commit into from
Oct 10, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Oct 8, 2024

Description:

Review

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review labels Oct 8, 2024
@sgiehl sgiehl added this to the 5.2.0 milestone Oct 8, 2024
@sgiehl sgiehl requested a review from a team October 8, 2024 15:53
@sgiehl sgiehl merged commit 0e5a975 into 5.x-dev Oct 10, 2024
25 checks passed
@sgiehl sgiehl deleted the dev-18576 branch October 10, 2024 07:02
sgiehl added a commit that referenced this pull request Oct 10, 2024
@sgiehl
Adds some tests around correct handling of formulas in CSV export (#2…
5ffbf56 
…2646)
@sgiehl sgiehl mentioned this pull request Oct 10, 2024
Merged
11 tasks
sgiehl added a commit that referenced this pull request Oct 10, 2024
@sgiehl
Adds some tests around correct handling of formulas in CSV export (#2…
0c5684b 
…2646)
@sgiehl sgiehl mentioned this pull request Oct 10, 2024
Merged
11 tasks
mneudert pushed a commit that referenced this pull request Oct 10, 2024
@sgiehl
Adds some tests around correct handling of formulas in CSV export (#2…
46c5f2c 
…2646) (#22654)
sgiehl added a commit that referenced this pull request Oct 14, 2024
@sgiehl
Adds some tests around correct handling of formulas in CSV export (#2…
027355b 
…2658)

* Adds some tests around correct handling of formulas in CSV export (#22646)

* Improve escaping of values in CSV exports (#21719)

* Improve escaping of values in CSV exports

* adjust tests

* updates expected test files

* fix marketplace test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner approved these changes

Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sgiehl @michalkleiner