-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Improve handling for changing email of invited users #22644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The mechanism works as expected. I'm not 100% sure on the wording of the notification as it looks like we are cautioning against something that may not even happen. I was actually expecting to have a confirmation dialog explaining the mechanism only when the email was changed, asking whether the superadmin wanted to continue. We might be alarming too many people as it is now. It's just my perception, should we consult this with product? Or merge it as is and do a follow up ticket that we will never get to? |
@michalkleiner I initially tried to extend the password confirmation to add the text in case the email was changed. But due to the way how the vue code is designed this is not fully possible. If you e.g. add a char and remove it again, that can't be detected. |
84a586d
to
43f32d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as expected and with the notification moved to the confirmation dialog also more user-friendly.
Description:
Matomo has the possibility to invite new users. When a user is invited an email with an activation link will be sent to their email address.
The details of a user, who has not yet confirmed their invitation, can already be changed by the super user. This also includes the initially set email address.
This PR improves the handling if the email address of an invited user is changed.
When this happens, the previous invitation link will be invalidated and a fresh invitation will be sent to the new email address.
Review