Skip to content

Use sha256 instead of md5 for file integrity checks #22602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 20, 2024
Merged

Use sha256 instead of md5 for file integrity checks #22602

merged 3 commits into from
Sep 20, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Sep 19, 2024 •
edited
Loading

Description:

Using sh256 instead of md5 will make the integrity check slightly more secure.

fixes #7029

Review

@sgiehl sgiehl added the c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. label Sep 19, 2024
@sgiehl sgiehl added this to the 5.2.0 milestone Sep 19, 2024
@sgiehl sgiehl requested a review from a team September 19, 2024 13:26
@sgiehl sgiehl added the Needs Review PRs that need a code review label Sep 19, 2024
@sgiehl sgiehl marked this pull request as ready for review September 19, 2024 13:26
mneudert
mneudert reviewed Sep 19, 2024
View reviewed changes
@sgiehl sgiehl requested a review from mneudert September 20, 2024 13:34
@mneudert mneudert merged commit 18513d6 into 5.x-dev Sep 20, 2024
24 of 25 checks passed
@mneudert mneudert deleted the dev-15464 branch September 20, 2024 15:57
jorgeuos pushed a commit to jorgeuos/matomo that referenced this pull request Oct 1, 2024
@sgiehl @jorgeuos
Use sha256 instead of md5 for file integrity checks (matomo-org#22602)
cbc77ae 
* use sha256 instead of md5 for file integrity checks

* apply review feedback

* updates expected UI test files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mneudert mneudert mneudert approved these changes

Assignees
No one assigned
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.

Consider using sha256 instead of md5 in config/manifest.inc.php
2 participants
@sgiehl @mneudert