Skip to content

Add configuration for database connection collation #22588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 13, 2024
Merged

Add configuration for database connection collation #22588

merged 3 commits into from
Sep 13, 2024

Conversation

mneudert
Copy link
Member

Description:

Cherry picks #22564 (and #22271 for preparation) for patch release.

Review

@mneudert mneudert marked this pull request as ready for review September 13, 2024 13:11
@mneudert mneudert added Needs Review PRs that need a code review Stability For issues that make Matomo more stable and reliable to run for sys admins. labels Sep 13, 2024
@mneudert mneudert added this to the 5.1.2 milestone Sep 13, 2024
@mneudert mneudert requested a review from a team September 13, 2024 13:12
sgiehl
sgiehl previously approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
But if we want to release a RC before 5.1.2, we might need to change the name of the update script accordingly...

@sgiehl sgiehl merged commit 30a811c into 5.1.x-dev Sep 13, 2024
21 of 25 checks passed
@sgiehl sgiehl deleted the dev-18459-51 branch September 13, 2024 14:24
@sgiehl sgiehl changed the title Add configuration for database connection collation (5.1.x) Add configuration for database connection collation Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review Stability For issues that make Matomo more stable and reliable to run for sys admins.
Milestone
5.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@mneudert @sgiehl