Skip to content

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Sep 2, 2024

Description:

The core:archive command provides a flag --skip-segments-today, which prevents segments data from being processed for today.

The currently implementation only prevents them from being processed. But invalidation done for today before archiving is started is currently done anyway. This causes also the higher periods (week, month, year) to be invalidated. But as only today is prevented from being archived for segments, those higher periods will be reprocessed anyway, even if there actually were no changes in lower periods.

To prevent this unnecessary archiving of those higher periods, this PR changes the behavior of the initial invalidation. If --skip-segments-today is provided, we will no longer create invalidations for segments for today (and periods including this day).
This shouldn't cause any problems even if the flag is used always when archiving is triggered, as yesterday will still be invalidated for segments.

Review

@sgiehl sgiehl added the Needs Review PRs that need a code review label Sep 2, 2024
@sgiehl sgiehl added this to the 5.2.0 milestone Sep 2, 2024
@mneudert mneudert merged commit 7cbe3b4 into 5.x-dev Sep 2, 2024
44 of 46 checks passed
@mneudert mneudert deleted the dev-19395_2 branch September 2, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Development

Successfully merging this pull request may close these issues.

2 participants