Skip to content

Sort goals by id in API response #22473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Sort goals by id in API response #22473

merged 2 commits into from
Aug 5, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Aug 5, 2024

Description:

Various reports contain goal metrics. Currently the order of the goals is a matter of how the database decides to return the goals in.

This PR adds a simply sorting by id, so the order will always be the same and independent from the database.

This will also help to fix certain tests failing for TiDb

Review

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review labels Aug 5, 2024
@sgiehl sgiehl added this to the 5.2.0 milestone Aug 5, 2024
@sgiehl sgiehl requested a review from a team August 5, 2024 10:10
@mneudert mneudert merged commit 0430b42 into 5.x-dev Aug 5, 2024
25 checks passed
@mneudert mneudert deleted the sortgoalsinapi branch August 5, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review
Development

Successfully merging this pull request may close these issues.

2 participants