Skip to content

Sort email reports by description in API & UI #22462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 2, 2024
Merged

Sort email reports by description in API & UI #22462

merged 2 commits into from
Aug 2, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 31, 2024 •
edited by caddoo
Loading

Description:

Due to differences in sorting between MySQL and TiDb, this PR also includes the possibility to create database specific config files. This allows to manually sort the API response in tests again for TiDb, so the result matches the expectations (created with MySQL)

refs #11643

(Ref DEV-14881)

Review

@sgiehl sgiehl added the Needs Review PRs that need a code review label Jul 31, 2024
@sgiehl sgiehl added this to the 5.2.0 milestone Jul 31, 2024
@sgiehl sgiehl requested a review from a team July 31, 2024 16:54
@sgiehl sgiehl force-pushed the sortemailreports branch from 596234c to 34caa6d Compare August 1, 2024 07:36
sgiehl added a commit that referenced this pull request Aug 1, 2024
@sgiehl
Apply #22462
ca702f6 
Squashed commit of the following:

commit 596234c
Author: sgiehl <stefan@matomo.org>
Date:   Wed Jul 31 18:41:58 2024 +0200

    allow database specific configs

commit bb7a4bd
Author: sgiehl <stefan@matomo.org>
Date:   Wed Jul 31 09:04:24 2024 +0200

    sort email reports by description
@michalkleiner michalkleiner merged commit 4cce522 into 5.x-dev Aug 2, 2024
25 checks passed
@michalkleiner michalkleiner deleted the sortemailreports branch August 2, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sgiehl @michalkleiner