Skip to content

Use Matomo coding standard repo #22421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2024
Merged

Use Matomo coding standard repo #22421

merged 2 commits into from
Aug 1, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Jul 19, 2024

Description:

Review

@sgiehl sgiehl force-pushed the use_matomo_cs branch 2 times, most recently from de75194 to 0ce6990 Compare July 19, 2024 08:45
@AltamashShaikh
Copy link
Contributor

@sgiehl Good that its passing now, once it gets merged we can start adding the test for plugins also

@sgiehl sgiehl marked this pull request as ready for review July 31, 2024 08:46
@sgiehl sgiehl requested a review from a team July 31, 2024 08:46
@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review labels Jul 31, 2024
michalkleiner
michalkleiner approved these changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. At some point in future we should probably add the repo to Packagist so that we don't have to use the repositories manual entry, and to also start using some simple versioning for the coding standards so that updates don't break things.

@sgiehl sgiehl added this to the 5.2.0 milestone Aug 1, 2024
@sgiehl sgiehl merged commit 1e35cae into 5.x-dev Aug 1, 2024
25 checks passed
@sgiehl sgiehl deleted the use_matomo_cs branch August 1, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner approved these changes

Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sgiehl @AltamashShaikh @michalkleiner