Add premium plugin menu items to professional services [4.x] #21394
Conversation
061223c to
6a9be62
Compare
6a9be62 to
ec46e0e
Compare
|
@caddoo Please avoid creating PRs for 4.x-dev unless features are meant to go into a 4.x release ONLY. |
I went for 4.x-dev first, due to us wanting to push it to that version first. Is there a reason it should be the other way? |
|
Always writing PRs for 5.x first ensures that nothing goes into 4.x that doesn't already exist in 5.x (so we don't unintentionally drop features) and that the technical design of the PR is build around 5.x capabilities first, rather than potentially writing for 4.x deprecated methods and then having a different solution for 5.x which increases review work and bug potential. I've reviewed this change, it works well and I can't see any issues, if you want to provide a 5.x version then I can review that too and get them both merged. |
|
With my work being dependent on this, should I create a PR on top of this or wait until a 5.x version exists, have my part tested and reviewed for 5.x first, and then backport? |
|
@michalkleiner If @caddoo can provide a 5.x version of this PR soon then it's probably easiest to create your 5.x version based on 5.x-dev after it's merged. |
fac829f to
61c324a
Compare
Description:
This is an addition to the professional services plugin that will show premium plugins in the reporting menu with an empty widget if:
The content / title of the widgets is being worked on in a seperate PR.
In this PR I have force disabled showing the menu items intentionally so we can merge this without impact, there are unit test s for the logic around whether to show the item or not.
Once approved / merged, the follow up for the promotional page can be added.
Screenshot when the logic is used without being fixed as false.
Review