Fix for "What's new" content visible when it shouldn't be #21341
Conversation
…ed, don't show plugin name prefix in title for professional services plugin
| 'Updater.componentUpdated' => 'addPluginChanges', | ||
| 'PluginManager.pluginUninstalled' => 'removePluginChanges' |
There was a problem hiding this comment.
Is it correct here to remove the hook for the plugin uninstallation?
There was a problem hiding this comment.
@michalkleiner Yes that's intentional, plugins are deactivated before they are uninstalled so the removePluginChanges() method will still be run when uninstalling, but also now if a plugin is deactivated but not uninstalled.
There was a problem hiding this comment.
This is actually not fully correct. Uninstalling a plugin triggers the deactivate method within the plugin class (if found). But that will actually not trigger the event.
The UI only provides an uninstall link for deactivated plugins, but there might be a scenario where you can uninstall a plugin in the UI without deactivating it first. Haven't tested that, but when you remove the plugin directly in the filesystem, I think the system will report it as broken, with the option to uninstall it. But the deactivate might not be triggered in that case.
Also there could be other scanarios where an activated plugin is uninstalled without a manual deactivation before. So might be better to keep that event as well.
There was a problem hiding this comment.
@bx80 do we want to return the event hook? It should cause no harm, right? Or would it effectively run twice and cause problems?
Description:
The "What's new" feature loaded change items from each plugin's
changes.jsonfile into the database, however this is happening even for plugins that are deactivated.This PR changes this behaviour to:
Review