use flex layout to be able shorten text to two lines #21304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333b9cc to
bfd4ab7
Compare
michalkleiner
approved these changes
Sep 26, 2023
sgiehl
added a commit
that referenced
this pull request
Sep 28, 2023
sgiehl
added a commit
that referenced
this pull request
Sep 29, 2023
* Allow custom loading message for widget loader * apply new layout to header and footer of no data page * implement layout of tracking method view * layout improvements * implement recommended method * add hidden share button for later * Refactor rendering into vue component * implement details view for tracking methods * implement url handling for tab selection * show notifications in details only if it was detectd * improve events and move some stuff to tagmanager * some layout tweaks * Consolidate EmptySite UI test suites into one * move test to tag manager * code cleanup * removes some unused translations * further adjustments to various method details * implement method to allow recommendation overwrite * allow selecting specific details view in css * implement global list styling * move tagmanager specific styling to plugin * remove GA3 and GA4 notifications from tracking code screen * remove no longer needed tests and fixtures * ensure url parameter uses same case as before * layout and code fixes * improve global list style * fix sorting * updates expected UI test files * submodule update * update outdated css selectors * avoid unnecessary screenshots in updater tests * fix parameter type hint * Move check for tracked data to vue component instead of reusing the live widget * don't show GA Import on others screen when plugin is available * improve layout so it works with two line names * use flex layout to be able shorten text to two lines (#21304) * remove indention of test feature result * fix sizing of code block elements in numbered lists * Improve handling of CTA buttons * adjust css * submodule update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
follow up to #21247 to improve layout further
Review