Skip to content

Prevent possible PHP error #21285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2023
Merged

Prevent possible PHP error #21285

merged 1 commit into from
Sep 21, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Sep 20, 2023

Description:

fixes #21282

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Sep 20, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Sep 20, 2023
@sgiehl sgiehl requested a review from a team September 20, 2023 08:03
michalkleiner
michalkleiner approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@michalkleiner michalkleiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@sgiehl sgiehl merged commit f7aa35e into 5.x-dev Sep 21, 2023
@sgiehl sgiehl deleted the m21282 branch September 21, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Fatal error: "Call to a member function getColumn() on null" in DataTableRowAction/RowEvolution.php
2 participants
@sgiehl @michalkleiner