Skip to content

Fix password handling when uploading plugins #21278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2023
Merged

Fix password handling when uploading plugins #21278

merged 1 commit into from
Sep 19, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Sep 19, 2023 •
edited
Loading

Description:

Due to using Common::getRequestVar for checking the password, this failed before if the password contains certain special chars like <.

fixes #21274

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Sep 19, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Sep 19, 2023
@mneudert mneudert self-assigned this Sep 19, 2023
@mneudert mneudert assigned sgiehl and unassigned mneudert Sep 19, 2023
@sgiehl sgiehl merged commit cf256fc into 5.x-dev Sep 19, 2023
@sgiehl sgiehl deleted the m21274 branch September 19, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mneudert mneudert mneudert approved these changes

Assignees

@sgiehl sgiehl

Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Upload & install plugin ZIP fails with "Wrong username and/or password."
2 participants
@sgiehl @mneudert