Prefill period selector comparison values from URL hash #21242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mneudert please either remove the Needs review label if the PR is still draft or move the PR from draft to 'full', at the moment I'm not sure if it's ready for review or not. |
e630b2c to
085db93
Compare
caddoo
reviewed
Sep 12, 2023
95166d1 to
4ce4f76
Compare
caddoo
approved these changes
Sep 13, 2023
michalkleiner
approved these changes
Sep 14, 2023
|
@mneudert feel free to merge once the conflicts were resolved by rebasing and rebuilding the vue files... |
Co-authored-by: caddoo <matthew.caddoo@gmail.com>
4ce4f76 to
d98107c
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The period selector does not keep information about the last selected comparison type (e.g "previous year" or "custom") across page reloads. Adding a new parameter containing the last type selection solves this issue without guessing the type based on the values of
compareDatesorcomparePeriods(or introducing custom period parsers).Fixes #20321.
Review