Skip to content

check dataTableActions CSS class when building label param for row evolution #21232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2023
Merged

check dataTableActions CSS class when building label param for row evolution #21232

merged 1 commit into from
Sep 7, 2023

Conversation

diosmosis
Copy link
Member

@diosmosis diosmosis commented Sep 7, 2023 •
edited
Loading

Description:

Since some premium features use the dataTableActions CSS class but a non-ActionsDataTabe JS type.

Refs #21122

Review

@diosmosis diosmosis force-pushed the no-client-side-row-evo-pretty-label-actions branch 2 times, most recently from 88adc69 to 76d5018 Compare September 7, 2023 02:49
@diosmosis diosmosis changed the title check for actions table w/ JS type instead of dataTableActions CSS class check dataTableActions CSS class when building label param for row evolution Sep 7, 2023
@diosmosis diosmosis requested a review from sgiehl September 7, 2023 02:51
@diosmosis diosmosis added Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Sep 7, 2023
@diosmosis
in DataTable_RowAction.trigger check for actions datatable using data…
08217b9 
…TableActions CSS class in addition to the table type property, as plugins can change that while still providing an actions like table
@diosmosis diosmosis force-pushed the no-client-side-row-evo-pretty-label-actions branch from 76d5018 to 08217b9 Compare September 7, 2023 02:55
@snake14 snake14 mentioned this pull request Sep 7, 2023
Merged
11 tasks
sgiehl
sgiehl approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to have no impact on core as expected, but if it fixes things for plugins that fine.

@sgiehl sgiehl added this to the 5.0.0 milestone Sep 7, 2023
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Sep 7, 2023
@sgiehl sgiehl merged commit 5bace7f into 5.x-dev Sep 7, 2023
@sgiehl sgiehl deleted the no-client-side-row-evo-pretty-label-actions branch September 7, 2023 09:47
diosmosis added a commit that referenced this pull request Sep 20, 2023
@diosmosis
missing some code in #21232
2216959
sgiehl pushed a commit that referenced this pull request Sep 21, 2023
@diosmosis
missing some code in #21232 (#21288)
2e9c706
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@diosmosis @sgiehl