Skip to content

Fix table header might overlay top control drop downs #21229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 6, 2023
Merged

Fix table header might overlay top control drop downs #21229

merged 2 commits into from
Sep 6, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Sep 6, 2023

Description:

fixes #21228

Review

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Sep 6, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Sep 6, 2023
michalkleiner
michalkleiner approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@michalkleiner michalkleiner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw the fix working locally on Stefan's machine, tests are updated and passing, I think this is good to go.

@sgiehl sgiehl merged commit 7e24dc0 into 5.x-dev Sep 6, 2023
@sgiehl sgiehl deleted the fixzindex branch September 6, 2023 15:33
@mneudert mneudert mentioned this pull request Sep 27, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkleiner michalkleiner michalkleiner approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Top control dropdown elements might be overlapped by table headers
2 participants
@sgiehl @michalkleiner