Skip to content

Fixes goals can't be saved when previously defined as event goal using event value as revenue #21208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2023
Merged

Fixes goals can't be saved when previously defined as event goal using event value as revenue #21208

merged 1 commit into from
Sep 1, 2023

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Aug 31, 2023 •
edited
Loading

Description:

Fixes a regression where a goal can't be saved, when it previously was defined as event goal using the event value as revenue, and switched to a non event goal.

fixes #17500

Review

@sgiehl sgiehl added the Needs Review PRs that need a code review label Aug 31, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Aug 31, 2023
@sgiehl sgiehl added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label Aug 31, 2023
@sgiehl sgiehl requested a review from AltamashShaikh August 31, 2023 10:06
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Aug 31, 2023
AltamashShaikh
AltamashShaikh reviewed Aug 31, 2023
View reviewed changes
Copy link
Contributor

@AltamashShaikh AltamashShaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solves the issue 👍

@sgiehl sgiehl merged commit 0b7b44f into 5.x-dev Sep 1, 2023
@sgiehl sgiehl deleted the fixeventgoal branch September 1, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AltamashShaikh AltamashShaikh AltamashShaikh approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

useEventValueAsRevenue still ticked after switching goal type
2 participants
@sgiehl @AltamashShaikh